Assorted minor optimizations #931

bad-co-de · 2024-09-22T15:02:25Z

See individual commits for information.

Currently the loop is only executed at most once, the break probably should be inside the if block.

Allocate the required memory at once.

Use find() instead of contains() followed by at().

Cache the value once.

erase() works fine if the key does not exist.

The sensor data is not modified for the lifetime of the vector and outlives it.

bad code added 14 commits September 22, 2024 16:43

Exit loop only if element found

bc39279

Currently the loop is only executed at most once, the break probably should be inside the if block.

Reserve known vector size

e8ad3da

Allocate the required memory at once.

Avoid copies in loop iterator

bb8b967

Avoid unnecessary copy of vector

f59d4da

Drop unnecessary string construction

5d41d29

Avoid repeated lookup

9d8a49b

Use find() instead of contains() followed by at().

Avoid repeated lookup

c1a65a3

Cache the value once.

Avoid repeated lookup

15ce5e1

erase() works fine if the key does not exist.

Initialize vector in one step

02a1971

Avoid string copy

0f1bb2a

Reduce variable scope

4fa1a8a

Drop unused struct members

5cf5712

Avoid string copies

9c35b38

The sensor data is not modified for the lifetime of the vector and outlives it.

Avoid copies in ltrim() and ltrim()

1454472

Provide feedback